linux-kernel - Re: [PATCH 1/2] kill FMODE_NDELAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 30 Nov 2008 13:07:23 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Christoph Hellwig <hch@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] kill FMODE_NDELAY_NOW

On Wed, Nov 05, 2008 at 02:58:42PM +0100, Christoph Hellwig wrote:
> Update FMODE_NDELAY before each ioctl call so that we can kill the
> magic FMODE_NDELAY_NOW.  It would be even better to do this directly
> in setfl(), but for that we'd need to have FMODE_NDELAY for all files,
> not just block special files.

We _can't_ do that in setfl() - not unless you such bdev method.
Note that there's a bunch of cases where O_NDELAY at open() is used
to get very different semantics and we want ->release() to see the
matching value.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/