linux-kernel - Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081130134048.GA28946@ZenIV.linux.org.uk>
Date:	Sun, 30 Nov 2008 13:40:48 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>, gregkh@...e.de,
	petero2@...ia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix pktcdvd breakage from commit
	e105b8bfc769b0545b6f0f395179d1e43cbee822

On Sun, Nov 30, 2008 at 01:32:29PM +0000, Al Viro wrote:
> On Sun, Nov 30, 2008 at 02:25:43PM +0100, Kay Sievers wrote:
> 
> > Pktcdvd creates char _and_ block device nodes at the same time, while
> > the char nodes are not allocated, but created and conflict in
> > /sys/dev/ with properly allocated ones from other subsystems. Your
> > patch just papers over this bug.
> 
> Where the hell is it creating any char device nodes?  Show me.
> And note that device_create() is not creating *any* device nodes,
> char or block.  It creates a directory in some place in sysfs,
> associated with struct device (which has arseloads of uses unrelated
> to block *or* char devices) and, if dev_t argument is non-zero,
> dumps its value into one of the attributes.
> 
> These days it might also dump a symlink into /sys/dev/*.
> 
> Which part of the above constitutes a creation of char device node?

Wait a minute...  Are you saying that something in userland ends up
seeing that sucker, noticing .../dev and proceeding to do mknod?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/