linux-kernel - Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 30 Nov 2008 14:13:29 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>, gregkh@...e.de,
	petero2@...ia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix pktcdvd breakage from commit
	e105b8bfc769b0545b6f0f395179d1e43cbee822

On Sun, Nov 30, 2008 at 02:57:14PM +0100, Kay Sievers wrote:
> > "It" being udev, presumably?
> 
> Yes, udev, mdev, and a few other tools people use to populate /dev
> from the kernel supplied device information.
> 
> > What a mess...  How does drivers/usb/core/devio.c avoid essentially the same
> > problem?
> 
> It's a special case, where two "struct device" have the same dev_t,
> but they both point to and handle the same device, so it's fine. The
> usb_device class is deprecated, no recent distro uses it, and will be
> removed some day.

Would that happened to udev as well...  Yeah, I know, but one can dream ;-/

Bloody wonderful.  So we have
	* userland-exposed layout of directory trees created by pktcdvd
	* uevent mess generated by device_create() and *also* userland-exposed

So we need to preserve the layout, with the easiest way probably being "add
one more ktype and use kobject_init_and_add() instead of that device_create()".
Sigh...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/