linux-kernel - Re: [PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0812011838440.11341@pc-004.diku.dk>
Date:	Mon, 1 Dec 2008 18:39:01 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	Olof Johansson <olof@...om.net>
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev_put

On Mon, 1 Dec 2008, Olof Johansson wrote:

> On Thu, Nov 27, 2008 at 01:19:49PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@...u.dk>
> > 
> > pci_get_device increments a reference count that should be decremented
> > using pci_dev_put.  I have thus added an extra label in the error handling
> > code to do this.  I don't know, however, whether there should be a
> > pci_dev_put before the return 0 as well.
> > 
> [...]
> 
> > Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> Acked-by: Olof Johansson <olof@...om.net>

Do you know the answer about the return 0?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/