linux-kernel - Re: [PATCH] Fujitsu Amilo PA 1510 key-release events quirk (PATCH 1/3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49345034.8050208@impulze.org>
Date:	Mon, 01 Dec 2008 21:59:32 +0100
From:	Daniel Mierswa <impulze@...ulze.org>
To:	linux-kernel@...r.kernel.org
CC:	linux-input@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] Fujitsu Amilo PA 1510 key-release events quirk (PATCH
 1/3)

Split patches as requested in "[PATCH] Fujitsu Amilo PA 1510 key-release
events quirk"
Here's the first out of 3.


On 30.11.2008 08:38, Andrew Morton wrote:
> Please don't send more than one patch per email.  I shall comment on
> the two patches in two separate replies.
>   
done, except that they are three now :)


On 30.11.2008 08:38, Andrew Morton wrote:
> Please also cc linux-input@...r.kernel.org on input-related patches.
>
>   
done


On 30.11.2008 08:38, Andrew Morton wrote:
> oh my.  Please, no.  Just write a C function:
>
> void atkbd_gen_release_event(unsigned int *keys, unsigned nr_keys)
> {
> 	...
> }
>
>   
done, I prefer that myself, although I first thought it might be a bad
idea to pass around pointers there, since
other developers might expect ARRAY_SIZE to work in gen_release_events.

-- 
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply 
know better than you do.
                --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22



View attachment "atkbd_gen_release_events.patch" of type "text/plain" (1911 bytes)