linux-kernel - RE: [PATCH] aerdrv: fix sanity check in report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D05DB80B95B23498C72C700BD6C2E0B023EC665@pdsmsx502.ccr.corp.intel.com>
Date:	Mon, 1 Dec 2008 15:58:25 +0800
From:	"Zhang, Yanmin" <yanmin.zhang@...el.com>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"Nguyen, Tom L" <tom.l.nguyen@...el.com>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] aerdrv: fix sanity check in report_resume

Acked.

Nice capture.

Yanmin

>>-----Original Message-----
>>From: Hidetoshi Seto [mailto:seto.hidetoshi@...fujitsu.com]
>>Sent: Monday, December 01, 2008 3:31 PM
>>To: linux-pci@...r.kernel.org; Nguyen, Tom L; Zhang, Yanmin
>>Cc: linux-kernel@...r.kernel.org
>>Subject: [PATCH] aerdrv: fix sanity check in report_resume
>>
>>What we have to check here before calling it is err_handler->resume.
>>It seems that this block have been copy&pasted from report_slot_reset.
>>
>>Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
>>---
>> drivers/pci/pcie/aer/aerdrv_core.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
>>b/drivers/pci/pcie/aer/aerdrv_core.c
>>index dfc63d0..aac7006 100644
>>--- a/drivers/pci/pcie/aer/aerdrv_core.c
>>+++ b/drivers/pci/pcie/aer/aerdrv_core.c
>>@@ -252,7 +252,7 @@ static void report_resume(struct pci_dev *dev, void *data)
>>
>> 	if (!dev->driver ||
>> 		!dev->driver->err_handler ||
>>-		!dev->driver->err_handler->slot_reset)
>>+		!dev->driver->err_handler->resume)
>> 		return;
>>
>> 	err_handler = dev->driver->err_handler;
>>--
>>1.6.0
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/