linux-kernel - A question about sparse: how to use __acquires() and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Dec 2008 20:59:54 +0100
From:	"Bart Van Assche" <bart.vanassche@...il.com>
To:	"kernel list" <linux-kernel@...r.kernel.org>
Cc:	"Vladislav Bolkhovitin" <vst@...b.net>,
	"Alexander Shishkin" <alexander.shishckin@...il.com>
Subject: A question about sparse: how to use __acquires() and __releases() correctly ?

Hello,

I'm helping to prepare the SCST source code for inclusion in the Linux
kernel by a.o. cleaning up sparse warnings. Although most of the SCST
source code has been annotated by this time it's still not clear to me
how to use __acquires() and __releases() correctly.

I will illustrate my questions via the following code from
net/core/dev.c, Linux kernel version 2.6.27.7:

void dev_seq_stop(struct seq_file *seq, void *v)
        __releases(dev_base_lock)
{
        read_unlock(&dev_base_lock);
}

The command "make C=2 M=net/core" produces the following output for
the above function (using a sparse binary built from the sparse git
repository, last updated on August 26, 2008):

net/core/dev.c:2579:2: warning: context problem in 'dev_seq_stop':
'_read_unlock' expected different context
net/core/dev.c:2579:2:    context 'lock': wanted >= 1, got 0

My questions are as follows:
* Which argument type should be passed to __releases() -- a pointer to
a lock structure or the lock strucure itself ? In the header file
include/linux/spinlock_api_smp.h a pointer is passed to __acquires()
and __releases(), while other code (like the above) passes the lock
structure itself to the __acquires() and __releases() annotations.
* If the __releases() annotation is used correctly in net/core/dev.c,
why does sparse complain about a context problem ?

Please keep me in CC -- I'm not subscribed to the LKML.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/