linux-kernel - Re: Regression from 2.6.26: Hibernation (possibly suspend) broken on Toshiba R500 (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0812011933050.3256@nehalem.linux-foundation.org>
Date:	Mon, 1 Dec 2008 19:42:48 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Greg KH <greg@...ah.com>, Ingo Molnar <mingo@...e.hu>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Len Brown <lenb@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Takashi Iwai <tiwai@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>
Subject: Re: Regression from 2.6.26: Hibernation (possibly suspend) broken
 on Toshiba R500 (bisected)

On Mon, 1 Dec 2008, Linus Torvalds wrote:
> 
> or something like that. And then we just need to figure out which setup 
> routine sets the wrong alignment flag,.

Oh, btw, one more thing: since it apparently sometimes _does_ resume 
from hibernation without all this, I'd also like to see the actual 
differences in /proc/ioports and /proc/iomem that happen as a result of 
the different alignment. 

I also really suspect we should add a whole "alignment" field to "struct 
resource", instead of the size-vs-start flags. The fact is, some PCI 
devices have alignment that is neither tied to size or anything else: I 
think some PCI bus resources are really always 4kB-aligned, for example 
(and aligning them by size will give a bigger alignment than actually 
required).

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/