linux-kernel - Re: leds/leds-pca9532.c: sleeping function called in .brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1228298607.9126.1.camel@ted>
Date:	Wed, 03 Dec 2008 10:03:27 +0000
From:	Richard Purdie <rpurdie@...ys.net>
To:	Guennadi Liakhovetski <lg@...x.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: leds/leds-pca9532.c: sleeping function called in
	.brightness_set()

On Mon, 2008-11-24 at 10:51 +0100, Guennadi Liakhovetski wrote:
> this seems to explicitly violate the API as documented in 
> include/linux/leds.h:
> 
> 	/* Set LED brightness level */
> 	/* Must not sleep, use a workqueue if needed */
> 	void		(*brightness_set)(struct led_classdev *led_cdev,
> 					  enum led_brightness brightness);
> 
> and also contradicts some other drivers, e.g., pca955x, which do use a 
> workqueue as suggested: leds-pca9532.c::pca9532_set_brightness uses a 
> mutex for locking and calls i2c_smbus functions directly. Needs to be 
> fixed (if it hasn't been fixed yet), probably, also vor 2.6.27-stable.

There is a patch queued to fix this now. I'll submit some fixes to
2.6.28-rcX shortly and then we can consider it for -stable.

Cheers,

Richard

-- 
Richard Purdie
Intel Open Source Technology Centre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/