[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081203192606.GC6549@hmsreliant.think-freely.org>
Date: Wed, 3 Dec 2008 14:26:06 -0500
From: Neil Horman <nhorman@...driver.com>
To: Mathieu Desnoyers <compudj@...stal.dyndns.org>
Cc: ltt-dev@...ts.casi.polymtl.ca, linux-kernel@...r.kernel.org
Subject: Re: [ltt-dev] [PATCH] add tracepoints to track change in napi
states on network receive
On Wed, Dec 03, 2008 at 01:21:33PM -0500, Mathieu Desnoyers wrote:
> * Mathieu Desnoyers (compudj@...stal.dyndns.org) wrote:
> > * Neil Horman (nhorman@...driver.com) wrote:
> > > On Wed, Dec 03, 2008 at 12:25:07PM -0500, Mathieu Desnoyers wrote:
> > > > Almost there :)
> > > >
> > > > There is a extra whitespace above,
> > > >
> > > > and also "schedule napi_struct" should probably be changed into
> > > > napi_struct only, this removes the whitespace and duplicated information
> > > > (I guess we know that given we are in event net_napi_schedule, this will
> > > > have something to do with schedule...). Same applies to trace_mark_tp
> > > > below.
> > > >
> > > > Thanks,
> > > >
> > > > Mathieu
> > >
> > >
> > > Sure, here you go, new patch
> > >
> > > Patch to trace napi states for various net devices and their napi instances.
> > > Traces scheduling, servicing and completion of a napi poll request.
> > >
> > > Regards
> > > Neil
> > >
> > > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > >
> >
> > Actually I notice that you used the old "DEFINE_TRACE" tracepoint API.
>
> The patch has been edited and folded into
> lttng-instrumentation-net.patch
> lttng-instrumentation-net-tracepoints-probes.patch
>
Thanks!
Neil
--
/****************************************************
* Neil Horman <nhorman@...driver.com>
* Software Engineer, Red Hat
****************************************************/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists