[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.1.10.0812031611000.29045@gandalf.stny.rr.com>
Date: Wed, 3 Dec 2008 16:11:56 -0500 (EST)
From: Steven Rostedt <rostedt@...dmis.org>
To: Andrew Morton <akpm@...ux-foundation.org>
cc: linux-kernel@...r.kernel.org, mingo@...e.hu, fweisbec@...il.com,
peterz@...radead.org, arjan@...radead.org, dave@...ux.vnet.ibm.com,
containers@...ts.osdl.org, ebiederm@...ssion.com,
sukadev@...ux.vnet.ibm.com, serue@...ibm.com, srostedt@...hat.com
Subject: Re: [PATCH 1/3] ftrace: graph of a single function
On Wed, 3 Dec 2008, Andrew Morton wrote:
> On Wed, 03 Dec 2008 15:36:57 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > +static struct seq_operations ftrace_graph_seq_ops = {
> > + .start = g_start,
> > + .next = g_next,
> > + .stop = g_stop,
> > + .show = g_show,
> > +};
>
> This could be static I think.
s/static/const/
Damn damn damn damn!!!! I said to myself, I need to add const there and
still forgot :-(
>
> It's probably not worth even commenting on or fixing this sort
> of thing. Just rely on someone(tm) doing periodic sweeps to
> fix them all up.
Still on my todo list for kernel/trace/*.c
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists