| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1228340921.6529.80.camel@vega.slimlogic.co.uk> Date: Wed, 03 Dec 2008 21:48:41 +0000 From: Liam Girdwood <lrg@...mlogic.co.uk> To: David Brownell <david-b@...bell.net> Cc: Mark Brown <broonie@...ena.org.uk>, lkml <linux-kernel@...r.kernel.org>, davej@...hat.com Subject: Re: [patch 2.6.28-rc7] regulator: catch some registration errors On Mon, 2008-12-01 at 21:50 -0800, David Brownell wrote: > From: David Brownell <dbrownell@...rs.sourceforge.net> > > Prevent registration of duplicate "struct regulator" names. > They'd be unavailable, and clearly indicate something wrong. This part is fine. > > Also make sure the consumer device is provided. It's nonsensical > to omit these, and not a documented part of the interface. Since > no code in mainline does such stuff, this is just anti-oops medicine. > I think Mark has probably mentioned the need to support CPUfreq drivers with no struct device. I had a quick scan of the current in tree ARM CPUfreq drivers and could not find one that uses struct device (someone will now find one). I wonder if there is another way to approach this as I do agree that passing NULL is probably not the best solution. Alternatives like embedding struct device with the CPUfreq core or adding a regulator_get API call for CPUfreq drivers all involve some work. Fwiw, I'd be happy enough with the latter option. Thanks Liam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists