linux-kernel - Re: [PATCH] percpu_counter: Fix __percpu_counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081203.221436.57914253.davem@davemloft.net>
Date:	Wed, 03 Dec 2008 22:14:36 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH] percpu_counter: Fix __percpu_counter_sum()

From: Eric Dumazet <dada1@...mosbay.com>
Date: Wed, 03 Dec 2008 21:24:36 +0100

> [PATCH] percpu_counter: Fix __percpu_counter_sum()
> 
> This function should not write into percpu local storage,
> without proper locking, or some changes done on other cpus
> might be lost.
> 
> Adding proper locking would need to use atomic
> operations in fast path and would be expensive.
> 
> Results of __percpu_counter_sum() can be wrong, this is a
> known fact.
> 
> We also dont need to acquire the lock, this gives
> no better results.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/