linux-kernel - Re: Conflict resolved in the security-testing tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081204181008.8a5c0f91.sfr@canb.auug.org.au>
Date:	Thu, 4 Dec 2008 18:10:08 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	James Morris <jmorris@...ei.org>
Cc:	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
	"J. Bruce Fields" <bfields@...ldses.org>
Subject: Re: Conflict resolved in the security-testing tree

Hi James,

On Thu, 4 Dec 2008 17:33:39 +1100 (EST) James Morris <jmorris@...ei.org> wrote:
>
> I resolved a conflict between the new creds API and the nfs4 server code 
> in 
> git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
> 
> per the patch below.  Please check.
> 
> 
> diff --cc fs/nfsd/nfs4recover.c
> index 9371ea1,b79ec93..0000000
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@@ -230,12 -224,10 +230,13 @@@ nfsd4_list_rec_dir(struct dentry *dir, 
>   	if (!rec_dir_init)
>   		return 0;
>   
>  -	nfs4_save_user(&uid, &gid);
>  +	status = nfs4_save_creds(&original_cred);
>  +	if (status < 0)
>  +		return status;
> + 	INIT_LIST_HEAD(dentries);
>   
>  -	filp = dentry_open(dget(dir), mntget(rec_dir.mnt), O_RDONLY);
>  +	filp = dentry_open(dget(dir), mntget(rec_dir.mnt), O_RDONLY,
>  +			   current_cred());
>   	status = PTR_ERR(filp);
>   	if (IS_ERR(filp))
>   		goto out;

That is exactly what I did in linux-next in Nov 25 and got no screams
then.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped