linux-kernel - Re: [PATCH] block: use min_not_zero in blk_queue_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081204075607.GG18255@kernel.dk>
Date:	Thu, 4 Dec 2008 08:56:07 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: use min_not_zero in blk_queue_stack_limits

On Thu, Dec 04 2008, FUJITA Tomonori wrote:
> This is against for-2.6.29 in the block tree.
> =
> From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Subject: [PATCH] block: use min_not_zero in blk_queue_stack_limits
> 
> zero is invalid for max_phys_segments, max_hw_segments, and
> max_segment_size. It's better to use use min_not_zero instead of
> min. min() works though (because the commit 0e435ac makes sure that
> these values are set to the default values, non zero, if a queue is
> initialized properly).
> 
> With this patch, blk_queue_stack_limits does the almost same thing
> that dm's combine_restrictions_low() does. I think that it's easy to
> remove dm's combine_restrictions_low.

Queued up for 2.6.29. It would be nice to get rid of the dm mirror of
this function...

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/