linux-kernel - Re: [PATCH 1/3] ftrace: graph of a single function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081204084118.GG32594@elte.hu>
Date:	Thu, 4 Dec 2008 09:41:18 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Andy Whitcroft <apw@...dowen.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, fweisbec@...il.com,
	peterz@...radead.org, arjan@...radead.org, dave@...ux.vnet.ibm.com,
	containers@...ts.osdl.org, ebiederm@...ssion.com,
	sukadev@...ux.vnet.ibm.com, serue@...ibm.com, srostedt@...hat.com
Subject: Re: [PATCH 1/3] ftrace: graph of a single function


* Steven Rostedt <rostedt@...dmis.org> wrote:

> 
> On Wed, 3 Dec 2008, Andrew Morton wrote:
> 
> > On Wed, 03 Dec 2008 15:36:57 -0500
> > Steven Rostedt <rostedt@...dmis.org> wrote:
> > 
> > > +static struct seq_operations ftrace_graph_seq_ops = {
> > > +	.start = g_start,
> > > +	.next = g_next,
> > > +	.stop = g_stop,
> > > +	.show = g_show,
> > > +};
> > 
> > This could be static I think.
> 
> s/static/const/
> 
> Damn damn damn damn!!!! I said to myself, I need to add const there and 
> still forgot :-(

No need to get stressed up about such details - we need checkpatch help 
for this.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/