linux-kernel - Re: [PATCH 2/3] fix warning of not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Dec 2008 11:12:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jianjun Kong <jianjun@...ux.org>
Cc:	rusty@...tcorp.com.au,
	Linux-Kernel-Mailing-List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] fix warning of not used variable


* Jianjun Kong <jianjun@...ux.org> wrote:

> 
> fix this warning:
> kernel/module.c:824: warning: ‘print_unload_info’ defined but not used
> print_unload_info() just used when CONFIG_PROC_FS was defined.
> 
> Signed-off-by: Jianjun Kong <jianjun@...ux.org>
> ---
>  kernel/module.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

NAK. Warnings do not need to be "fixed", then need to be looked at and 
then there are two approaches:

 1) GCC is wrong => annotate the code
 2) GCC is right => fix the code

Your patch does not give us any idea about which case this is, whether 
you have analyzed the reason why GCC emitted that warning.

Besides, i dont see such warnings in kernel/module.c with latest GCC.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/