linux-kernel - Re: 2.6.28-rc6: early panic with boot option "nosmp"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081204122817.GA14840@localhost>
Date:	Thu, 4 Dec 2008 20:28:17 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jack Steiner <steiner@....com>, Yinghai Lu <yinghai@...nel.org>
Subject: Re: 2.6.28-rc6: early panic with boot option "nosmp"

On Thu, Dec 04, 2008 at 02:33:35PM +0200, Andi Kleen wrote:
> > The exception raised on dereferencing mpf or mpf_found.
> 
> This obvious patch should fix it then. Does it?

Yes, it boots OK now with your patch.

Thanks,
Fengguang

> --
> 
> Fix early exception in __get_smp_config with nosmp
> 
> Bail out early when there is no MP table.
> 
> Reported by Wu Fengguang
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> 
> ---
>  arch/x86/kernel/mpparse.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6.28-rc4-test/arch/x86/kernel/mpparse.c
> ===================================================================
> --- linux-2.6.28-rc4-test.orig/arch/x86/kernel/mpparse.c	2008-10-24 13:34:40.000000000 +0200
> +++ linux-2.6.28-rc4-test/arch/x86/kernel/mpparse.c	2008-12-04 13:20:34.000000000 +0100
> @@ -604,6 +604,9 @@
>  		printk(KERN_INFO "Using ACPI for processor (LAPIC) "
>  		       "configuration information\n");
>  
> +	if (!mpf)
> +		return;
> +
>  	printk(KERN_INFO "Intel MultiProcessor Specification v1.%d\n",
>  	       mpf->mpf_specification);
>  #if defined(CONFIG_X86_LOCAL_APIC) && defined(CONFIG_X86_32)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/