linux-kernel - Re: [Experimental][PATCH 21/21]memcg-new-hierarchical-reclaim.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44799.10.75.179.61.1228394692.squirrel@webmail-b.css.fujitsu.com>
Date:	Thu, 4 Dec 2008 21:44:52 +0900 (JST)
From:	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>
To:	"Daisuke Nishimura" <nishimura@....nes.nec.co.jp>
Cc:	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"balbir@...ux.vnet.ibm.com" <balbir@...ux.vnet.ibm.com>,
	nishimura@....nes.nec.co.jp
Subject: Re: [Experimental][PATCH  
     21/21]memcg-new-hierarchical-reclaim.patch

Daisuke Nishimura said:
> On Wed, 3 Dec 2008 14:14:23 +0900, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@...fujitsu.com> wrote:
>> Implement hierarchy reclaim by cgroup_id.

>> +	rcu_read_lock();
>> +	if (!root_mem->use_hierarchy) {
>> +		spin_lock(&root_mem->reclaim_param_lock);
>> +		root_mem->scan_age++;
>> +		spin_unlock(&root_mem->reclaim_param_lock);
>> +		css_get(&root_mem->css);
>> +		goto out;
>>  	}
>>
> I think you forgot "ret = root_mem".
> I got NULL pointer dereference BUG in my test(I've not tested
> use_hierarchy case yet).
>
yes...thank you for catching. will fix.

-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/