linux-kernel - Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081204134845.6c1df66b@gondolin>
Date:	Thu, 4 Dec 2008 13:48:45 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Greg K-H <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG

On Wed, 3 Dec 2008 15:12:03 -0500,
Jason Baron <jbaron@...hat.com> wrote:

> indeed. you raise the more general question of what do if both 'DEBUG'
> and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
> general the 'DEBUG' should take precedence, as you point out. However, I
> think we should fix this by reshuffling the logic in
> include/linux/kernel.h by doing:
> 
> if (DEBUG)
> 	#define pr_debug printk
> elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
> 	#define pr_debug dynamic_pr_debug()
> else
> 	#define pr_debug if (0) blah:
> endif
> 
> make sense? what do you think?

Yes, that makes sense, I agree. I'll follow up with a patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/