lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081204131752.GA16905@mail.local.tull.net>
Date:	Fri, 5 Dec 2008 00:17:52 +1100
From:	Nick Andrew <nick@...k-andrew.net>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trivial: printk: fix indentation of new_text_line	declaration

On Thu, Dec 04, 2008 at 12:44:34PM +0100, Jiri Kosina wrote:
> I have just come across bogus indentation of new_text_line declaration. I 
> have applied the patch below to trivial tree. If the indentation had some 
> specific non-obvious purpose and was done intentionally this way, please 
> let me know :)

That's cool. Ingo tweaked my patch and moved the static declaration
outside the function and mistakenly left the indent in place.

I'm actually not too happy about new_text_line being a static; I may
well submit a patch to fix that. But in the meantime, fixing the indent
is fine.

> From: Jiri Kosina <jkosina@...e.cz>
> Subject: trivial: printk: fix indentation of new_text_line declaration
> 
> Remove bogus indentation of new_text_line declaration introduced in
> commit ac60ad741.
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Acked-by: Nick Andrew <nick@...k-andrew.net>

Nick.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ