[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081205004849.GX6703@one.firstfloor.org>
Date: Fri, 5 Dec 2008 01:48:49 +0100
From: Andi Kleen <andi@...stfloor.org>
To: Mikulas Patocka <mpatocka@...hat.com>
Cc: Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
xfs@....sgi.com, Alasdair G Kergon <agk@...hat.com>,
Andi Kleen <andi-suse@...stfloor.org>,
Milan Broz <mbroz@...hat.com>
Subject: Re: Device loses barrier support (was: Fixed patch for simple barriers.)
> And if barriers fail at random points, the user can't turn on disk cache
> anyway (he would get data corruption if barrier write failed and hardware
I think we already established earlier in the thread that there is no disk
corruption
> > > I'm wondering, where in fsync() does Linux wait for hardware disk cache to
> > > be flushed? Isn't there a bug that fsync() will return before the cache is
> > > flushed? I couldn't really find it. The last thing do_fsync calls is
> > > filemap_fdatawait and it doesn't do cache flush (blkdev_issue_flush).
> >
> > At least in fsync() on journaling fs the metadata update should push it.
> >
> > -Andi
>
> And what about fdatasync()?
I don't know. The surest way to find out is to instrument it and try.
-Andi
--
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists