linux-kernel - Re: Regression from 2.6.26: Hibernation (possibly suspend) broken on Toshiba R500 (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0812041645290.3543@nehalem.linux-foundation.org>
Date:	Thu, 4 Dec 2008 16:45:47 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Frans Pop <elendil@...net.nl>, Greg KH <greg@...ah.com>,
	Ingo Molnar <mingo@...e.hu>, jbarnes@...tuousgeek.org,
	lenb@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	tiwai@...e.de, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Regression from 2.6.26: Hibernation (possibly suspend) broken
 on Toshiba R500 (bisected)


On Thu, 4 Dec 2008, Linus Torvalds wrote:
> 
> On Fri, 5 Dec 2008, Rafael J. Wysocki wrote:
> > 
> > There's a difference, though.  It doesn't cause the resources flags to be
> > cleared for the cardbus bridge and the cardbus bridge gets the correct sizes
> > of both prefetchable and non-prefetchable windows (64 MB).
> 
> Yes, true. In that sense, it minimizes the differences between the 
> "working" and "nonworking" case. 

Hmm. 

One other issue: we've been looking mostly at MMIO, but another thing that 
differs here is the PIO part.

Your patch only changes pbus_size_mem(), so what happens is that it avoids 
allocating the prefetch window. But it still allocates the PIO window, 
because pbus_size_io() is still run.

Maybe the PIO window matters? Any magic suspend registers are usually in 
PIO space, not in MMIO space. Did /proc/ioports change, and if so, how? 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/