linux-kernel - Re: [PATCH] crypto: des: fix inverted weak key flag check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <49394096.6080402@redhat.com>
Date:	Fri, 05 Dec 2008 09:54:14 -0500
From:	Jarod Wilson <jarod@...hat.com>
To:	linux-crypto@...r.kernel.org
CC:	Neil Horman <nhorman@...driver.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: des: fix inverted weak key flag check

Jarod Wilson wrote:
> Based on the fact the testmgr code sets the weak key flag for
> vectors with wk = 1, the weak key flag check in des_setkey()
> is backwards. Also, add a warning when a weak key is rejected,
> otherwise you silently get a bogus result back.
> 
> Signed-off-by: Jarod Wilson <jarod@...hat.com>

Self-NAK. Due to mail server issues, this might show up before the 
original...

My understanding of the flag's meaning appears to be backwards, Herbert 
pointed out that the use of this flag is self-consistent. Also, the 
printk probably shouldn't be there, the caller should check retval and 
complain if need be.


-- 
Jarod Wilson
jarod@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/