linux-kernel - Re: [PATCH] EXPORTFS: Don't return NULL from fh_to_dentry()/fh_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0812051608330.2982@blonde.anvils>
Date:	Fri, 5 Dec 2008 16:15:19 +0000 (GMT)
From:	Hugh Dickins <hugh@...itas.com>
To:	David Howells <dhowells@...hat.com>
cc:	torvalds@...l.org, akpm@...ux-foundation.org, bfields@...ldses.org,
	hch@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EXPORTFS: Don't return NULL from fh_to_dentry()/fh_to_parent()
 [ver #2]

On Fri, 5 Dec 2008, David Howells wrote:
> Hugh Dickins <hugh@...itas.com> wrote:
> 
> > I think it's still wrong in shmem_fh_to_dentry(): you've fixed
> > the early return, but there'd be another return NULL if !inode?
> 
> Now that I've fixed that as well, what are the chances of d_find_alias()
> returning NULL, do you think?  I suppose all that's required is for a file to
> be deleted locally while a remote client has a filehandle to it.

To be honest, I've no idea - you and hch know what goes on there
much better than I do.  Unless there's an obvious reason why an
incore filesystem like tmpfs or ramfs can't get a NULL there,
I think you have to add that protection too.  Sorry, it should
have crossed my mind too before I misled you by saying "!inode".

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/