linux-kernel - Re: [irda-users] [PATCH] OMAP IrDA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081205203216.GJ9714@atomide.com>
Date:	Fri, 5 Dec 2008 12:32:18 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Trilok Soni <soni.trilok@...il.com>
Cc:	samuel@...tiz.org, linux-kernel@...r.kernel.org,
	irda-users@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-omap@...r.kernel.org
Subject: Re: [irda-users] [PATCH] OMAP IrDA driver

Hi,

Just one comment below.

* Trilok Soni <soni.trilok@...il.com> [081205 01:48]:
> Hi Samuel,
> 
> On Fri, Dec 5, 2008 at 2:58 PM,  <samuel@...tiz.org> wrote:
> >
> > Hi,
> >
> > On Fri, 5 Dec 2008 12:04:29 +0530, "Trilok Soni" <soni.trilok@...il.com>
> > wrote:
> >> This time adding LKML too.
> > Could you please inline the patch so that we can have an easier review ?
> 
> I don't have proper git-send-email integration with gmail, so I am
> going to copy/paste this patch here:

<snip>

> diff --git a/drivers/net/irda/omap-ir.c b/drivers/net/irda/omap-ir.c
> new file mode 100644
> index 0000000..bf29585
> --- /dev/null
> +++ b/drivers/net/irda/omap-ir.c
> @@ -0,0 +1,893 @@

<snip>

> +
> +/*
> + * Set the IrDA communications speed.
> + * Interrupt have to be disabled here.
> + */
> +static int omap_irda_startup(struct net_device *dev)
> +{
> +	struct omap_irda *omap_ir = netdev_priv(dev);
> +
> +	/* FIXME: use clk_* apis for UART3 clock*/
> +	/* Enable UART3 clock and set UART3 to IrDA mode */
> +	if (machine_is_omap_h2() || machine_is_omap_h3())
> +		omap_writel(omap_readl(MOD_CONF_CTRL_0) | (1 << 31) | (1 << 15),
> +				MOD_CONF_CTRL_0);
> +
> +	/* Only for H2?
> +	 */
> +	if (omap_ir->pdata->transceiver_mode && machine_is_omap_h2()) {
> +		/* Is it select_irda on H2 ? */
> +		omap_writel(omap_readl(FUNC_MUX_CTRL_A) | 7,
> +					FUNC_MUX_CTRL_A);
> +		omap_ir->pdata->transceiver_mode(omap_ir->dev, IR_SIRMODE);
> +	}
> +

It would be best to get rid of the machine_is this or that code in the
drivers, and pass the necessary flags in the platform_data.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/