linux-kernel - Re: [PATCH] Use vprintk rather that vsnprintf where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3eb2510812041905j639ea7d4ybe8e83b0d7c5965e@mail.gmail.com>
Date:	Fri, 5 Dec 2008 04:05:06 +0100
From:	"Kay Sievers" <kay.sievers@...y.org>
To:	"Matt Mackall" <mpm@...enic.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Use vprintk rather that vsnprintf where possible

On Thu, Dec 4, 2008 at 21:41, Matt Mackall <mpm@...enic.com> wrote:
> This does away with lots of large static and on-stack buffers as well
> as a few associated locks.

> -               len = snprintf(s, 256, KERN_DEBUG "%s: ", prefix);
> -
>                va_start(args, fmt);
> -               len += vsnprintf(&s[len], (256 - len), fmt, args);
> +               printk(KERN_DEBUG "%s: ", prefix);
> +               vprintk(fmt, args);

If we convert to two printk calls for a single line, does that not
possibly get mixed up with printks from other locations and lead to
hardly readable log output?

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/