linux-kernel - Re: [patch,rfc] usb: restore config before enabling device on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812061602.26002.elendil@planet.nl>
Date:	Sat, 6 Dec 2008 16:02:23 +0100
From:	Frans Pop <elendil@...net.nl>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg KH <greg@...ah.com>, Ingo Molnar <mingo@...e.hu>,
	jbarnes@...tuousgeek.org, lenb@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	tiwai@...e.de, Andrew Morton <akpm@...ux-foundation.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [patch,rfc] usb: restore config before enabling device on resume

On Saturday 06 December 2008, Rafael J. Wysocki wrote:
> In fact, I think you could even move the pci_restore_state(dev) into
> usb_hcd_pci_resume_early() that would be executed with interrupts off
> and drop the pci_set_power_state(dev, PCI_D0); entirely (the
> pci_enable_device(dev); would invoke it anyway).

There is quite a lot going on in the resume function that happens before 
pci_restore_state is called and I'm absolutely not confident with messing 
with that, so I'll leave anything more invasive to the USB maintainers.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/