linux-kernel - Re: [PATCH] Staging: convert to list_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 6 Dec 2008 23:37:40 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: convert to list_for_each()

On Sat, Dec 06, 2008 at 09:49:05PM +0300, Alexander Beregalov wrote:

No, switch to list_for_each_entry() from the very beginning.

> --- a/drivers/staging/me4000/me4000.c
> +++ b/drivers/staging/me4000/me4000.c
> @@ -542,8 +542,7 @@ static void clear_board_info_list(void)
>  	struct me4000_ao_context *ao_context;
>  
>  	/* Clear context lists */
> -	for (board_p = me4000_board_info_list.next;
> -	     board_p != &me4000_board_info_list; board_p = board_p->next) {
> +	list_for_each(board_p, &me4000_board_info_list) {
>  		board_info = list_entry(board_p, struct me4000_info, list);
>  		/* Clear analog output context list */
>  		while (!list_empty(&board_info->ao_context_list)) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/