linux-kernel - Re: [RFC] Recursive printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081206231626.GK5957@mail.local.tull.net>
Date:	Sun, 7 Dec 2008 10:16:26 +1100
From:	Nick Andrew <nick@...k-andrew.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [RFC] Recursive printk

On Sat, Dec 06, 2008 at 01:11:33AM -0800, Joe Perches wrote:
> I think the question is how to output messages that use
> multiple calls to printk so they are not interleaved.

This is certainly needed e.g. for code which outputs line fragments
and expects full lines in the log, such as hex dumps. But its arguable
that that code should use its own buffer to format lines, then send
only complete lines to printk.

> Giving up printf argument verification seems too high a
> price to pay for the benefit of recursion.

I agree completely. I was hoping somebody could tell me how to include
'%v' in gcc's acceptable list, but it seems impossible. The alternative
then is to use '%pV%s' which gcc _should_ like (I haven't tested it,
but it seems reasonable) and reverse the order of the fmt and args
in the function call arguments.

Nick.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/