linux-kernel - Re: [RFC PATCH v1 3/3] Sample refactor of socket.c to use recursive printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24518.1228547914@turing-police.cc.vt.edu>
Date:	Sat, 06 Dec 2008 02:18:34 -0500
From:	Valdis.Kletnieks@...edu
To:	Nick Andrew <nick@...k-andrew.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 3/3] Sample refactor of socket.c to use recursive printk

On Sat, 06 Dec 2008 18:00:23 +1100, Nick Andrew said:
> Sample refactor of socket.c to use recursive printk

I think we'd all appreciate it a lot if, instead of pointless code churn
in socket.c, you used it to fix an *actual* problem - like any of the
many places where we have issues with interleaved output in dmesg because
a function had to use 2 or 3 printk calls to build up a line.

In your 0/3 you point at sound/core/misc.c and drivers/cpufreq/cpufreq.c,
both of those would be better than socket.c

Content of type "application/pgp-signature" skipped