linux-kernel - Re: Runaway loop with the current git.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081207200008.5af2d1e9@lxorguk.ukuu.org.uk>
Date:	Sun, 7 Dec 2008 20:00:08 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Kay Sievers" <kay.sievers@...y.org>
Cc:	"Evgeniy Polyakov" <zbr@...emap.net>,
	"Herbert Xu" <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org,
	"Linux Crypto Mailing List" <linux-crypto@...r.kernel.org>
Subject: Re: Runaway loop with the current git.

> >        max_modprobes = min(max_threads/2, MAX_KMOD_CONCURRENT);
> >        atomic_inc(&kmod_concurrent);
> >        if (atomic_read(&kmod_concurrent) > max_modprobes) {
> >                /* We may be blaming an innocent here, but unlikely */
> >                if (kmod_loop_msg++ < 5)
> >                        printk(KERN_ERR
> >                               "request_module: runaway loop modprobe
> > %s\n", module_name);
> >                atomic_dec(&kmod_concurrent);
> >                return -ENOMEM;
> >        }
> >
> > Happy now. Print it out, share it with friends, find someone who can read
> > C if you are stuck.
> 
> It does not work, that's all. 

It works for me. 

> Reproduce the bug and look at it for yourself.

Well since you've got a reproducer and this code works for me (I've tested
it just fine), why don't you go and reproduce the problem then post a fix
to that code I quoted instead of all this reordering rubbish. If you fix
this code not only won't you risk all the mess from re-ordering
initialisations around the kernel but you'll fix non console related
looping which you imply is also broken as you claim that code doesn't
work for you.

If I deliberately break my module utils I see a sequence of modprobes
which then hits kmod_concurrent limit then causes a -ENOMEM back to
userspace which then fails the file open. The bug report also shows the
printk is displayed so the runaway loop *was* detected and the code paths
taken which stopped the loop.

I get open -> modprobe -> open -> modprobe -> open -> modprobe ... ->
open fail, then open fail, open fail, open fail, open fail back to the
first modprobe exiting.

Your proposal to keep the current recent modprobe parameter strings would
shorten the amount of recursion but it wouldn't change the result that I
can see. If I open /dev/console early and wrongly from a modprobe then I
ultimately get a failing open just as I should do.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/