linux-kernel - Re: Runaway loop with the current git.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081207043116.GA12161@ioremap.net>
Date:	Sun, 7 Dec 2008 07:31:16 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: Runaway loop with the current git.

On Sun, Dec 07, 2008 at 04:56:04AM +0100, Kay Sievers (kay.sievers@...y.org) wrote:
> I was able to reproduce it with the .config you attached, and running it in kvm.
> 
> It is caused by:
>   "modprobe cryptomgr" called from swapper[1]
> 
> This modprobe process does try to log an error, accesses /dev/console,
> which is not initialized in the kernel at that time, and the kernel
> module loader tries the load a module to support dev_t 5:1, which
> again runs modprobe, and ...
> 
> Setting CONFIG_CRYPTO_MANAGER=y makes it disapper. The patch I sent
> seems to fix it.

Great to know it works. I will test it when get access to the machine
after the weekend.

> The bug is handled here: http://bugzilla.kernel.org/show_bug.cgi?id=12153

There is a good point in the thread, that hotplug should not call
recursion, but while this may be very valid requirement, it is _very_
subtle, and something more solid should be done. Just an opinion.

Initialization reordering is likely also not what we want, but simple
dumb console (or just dummy device which will accept data and will be
replaced later) sounds like a way to go, and your patch seems to allow
that dumb class registration first.
I actually used to believe that it works that way already...

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/