linux-kernel - Re: [PATCH 1/1] fs: fix warning message with inserting a single space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Dec 2008 14:24:28 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Artem Bityutskiy <dedekind@...dex.ru>
Cc:	Nick Andrew <nick@...k-andrew.net>,
	Hiroshi DOYU <Hiroshi.DOYU@...ia.com>,
	linux-kernel@...r.kernel.org, apw@...dowen.org
Subject: Re: [PATCH 1/1] fs: fix warning message with inserting a single	space

Am Montag, 8. Dezember 2008 14:16:05 schrieb Artem Bityutskiy:
> Nick Andrew wrote:
> > On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
> >> -			printk(KERN_WARNING "%s: %s passed in a files array"
> >> +			printk(KERN_WARNING "%s: %s passed in a files array "
> >>  				"with an index of 1!\n", __func__,
> >>  				s->s_type->name);
> > 
> > Yep. These look like the same kind of thing:
> > 
> > arch/powerpc/platforms/cell/iommu.c +1109
> >                                 pr_debug("iommu: hash window doesn't fit in"
> >                                          "real DMA window\n");
> 
> Do we have such kind of check in checkpatch.pl? Would be useful.

No, it wouldn't. A kernel message should be grepable. So, when in doubt,
screw the screen width limit. Don't make making ungreppable messages
easier.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/