linux-kernel - [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9df5fa10812080656l21385db3ob08fc4f9ad3f1f76@mail.gmail.com>
Date:	Mon, 8 Dec 2008 20:56:38 +0600
From:	"Rakib Mullick" <rakib.mullick@...il.com>
To:	"Linux-kernel Mailing List" <linux-kernel@...r.kernel.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ingo Molnar" <mingo@...e.hu>
Subject: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c

Impact: Fix compilation warning.

 CC      arch/x86/kernel/paravirt-spinlocks.o
arch/x86/kernel/paravirt-spinlocks.c: In function `default_spin_lock_flags':
arch/x86/kernel/paravirt-spinlocks.c:12: warning: passing arg 1 of
`__raw_spin_lock' from incompatible pointer type

This patch fixes the above warning.  __raw_spin_lock(lock) is declared
when CONFIG_SMP is defined. Thus, a call to __raw_spin_lock requires
checking CONFIG_SMP is defined or not.

Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>

--- linux-2.6-orig/arch/x86/kernel/paravirt-spinlocks.c	2008-12-05
19:53:15.000000000 +0600
+++ linux-2.6/arch/x86/kernel/paravirt-spinlocks.c	2008-12-07
23:52:59.000000000 +0600
@@ -9,7 +9,9 @@

 static void default_spin_lock_flags(struct raw_spinlock *lock,
unsigned long flags)
 {
+#ifdef	CONFIG_SMP
 	__raw_spin_lock(lock);
+#endif
 }

 struct pv_lock_ops pv_lock_ops = {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/