linux-kernel - Re: [PATCH] vmscan: skip freeing memory from zones with lots free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Dec 2008 02:48:40 +0900
From:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Rik van Riel" <riel@...hat.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	"Peter Zijlstra" <peterz@...radead.org>,
	"Johannes Weiner" <hannes@...xchg.org>,
	"Christoph Lameter" <cl@...ux-foundation.org>,
	"Nick Piggin" <npiggin@...e.de>
Subject: Re: [PATCH] vmscan: skip freeing memory from zones with lots free

> example,
>
>  Called zone_watermark_ok(zone, 2, pages_min, 0, 0);
>  pages_min  = 64
>  free pages = 80
>
> case A.
>
>     order    nr_pages
>   --------------------
>      2         5
>      1        10
>      0        30
>
>        -> zone_watermark_ok() return 1
>
> case B.
>
>     order    nr_pages
>   --------------------
>      3        10
>      2         0
>      1         0
>      0         0
>
>        -> zone_watermark_ok() return 0

Doh!
this example is obiously buggy.

I guess Mr. KOSAKI is very silly or Idiot.
I recommend to he get feathery blanket and good sleeping, instead
black black coffee ;-)


...but below mesurement result still true.

> This patch change zone_watermark_ok() logic to prefer large contenious block.
>
>
> Result:
>
>  test machine:
>    CPU: ia64 x 8
>    MEM: 8GB
>
>  benchmark:
>    $ tbench 8  (three times mesurement)
>
>    tbench works between about 600sec.
>    alloc_pages() and zone_watermark_ok() are called about 15,000,000 times.
>
>
>              2.6.28-rc6                        this patch
>
>       throughput    max-latency       throughput       max-latency
>        ---------------------------------------------------------
>        1480.92         20.896          1,490.27        19.606
>        1483.94         19.202          1,482.86        21.082
>        1478.93         22.215          1,490.57        23.493
>
> avg     1,481.26        20.771          1,487.90        21.394
> std         2.06         1.233              3.56         1.602
> min     1,478.93        19.202          1,477.86        19.606
> max     1,483.94        22.215          1,490.57        23.493
>
>
> throughput improve about 5MB/sec. it over measurement wobbly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/