linux-kernel - Re: [PATCH] nohz: add missing handling of clocksource watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812080124.37944.bzolnier@gmail.com>
Date:	Mon, 8 Dec 2008 01:24:37 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	"R. J. Wysocki" <Rafal.Wysocki@....edu.pl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Lars Winterfeld <lars.winterfeld@...ilmenau.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nohz: add missing handling of clocksource watchdog

On Monday 08 December 2008, Sergei Shtylyov wrote:
> Hello.
> 
> R. J. Wysocki wrote:
> > On Monday, 8 of December 2008, Bartlomiej Zolnierkiewicz wrote:
> >   
> >> Fixes "Clocksource tsc unstable (delta = -974982308 ns)" problem.
> >>     
> >
> > Where can I find the description of the problem?
> >   
> 
>    Kernel.org bug #10216 (it's not about this issue though).

Looking back at bug #10216 the patch is unlikely to help Lars' system
since it doesn't use nohz and there are also warnings about unsynced
TSCs (I just don't know why not for 2.6.27-rc kernels)...
 
> > Rafael
> >
> >   
> >> [ IDE was unlucky to be initialized at the same time that
> >>   clocksource watchdog triggers and was blamed for the issue. ]
> >>     
> 
>    I think it might well have been blamed correctly -- the clocksource 
> watchdog timer gets run every half second.

AFAICS this is a special one for measuring stability of the clocksource
only -- by comparing the value returned by a given clocksource with the
reference clocksource.  Normal drivers have no bussiness there...

Anyway I forgot to add that it fixes the issue for me under QEMU (on my
laptop TSC is unstable due to halts in idle) and it could be as well QEMU's
oddity (although it looks like a legit kernel problem).  v2 of the patch
below (updated patch description).

From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: [PATCH v2] nohz: add missing handling of clocksource watchdog

Fixes "Clocksource tsc unstable (delta = -974982308 ns)" problem
under QEMU.

Cc: Sergei Shtylyov <sshtylyov@...mvista.com>
Cc: Lars Winterfeld <lars.winterfeld@...ilmenau.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---
 kernel/time/tick-sched.c |    2 ++
 1 file changed, 2 insertions(+)

Index: b/kernel/time/tick-sched.c
===================================================================
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -21,6 +21,7 @@
 #include <linux/sched.h>
 #include <linux/tick.h>
 #include <linux/module.h>
+#include <linux/clocksource.h>
 
 #include <asm/irq_regs.h>
 
@@ -153,6 +154,7 @@ void tick_nohz_update_jiffies(void)
 	local_irq_restore(flags);
 
 	touch_softlockup_watchdog();
+	clocksource_touch_watchdog();
 }
 
 static void tick_nohz_stop_idle(int cpu)
.