linux-kernel - Re: [PATCH 5/5] irq: move irq_desc according to smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440812081118u4b29f8bag4224997e1020056d@mail.gmail.com>
Date:	Mon, 8 Dec 2008 11:18:01 -0800
From:	"Yinghai Lu" <yinghai@...nel.org>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] irq: move irq_desc according to smp_affinity v5

On Mon, Dec 8, 2008 at 5:42 AM, Ingo Molnar <mingo@...e.hu> wrote:
>
>>                       mask_ack_irq(desc, irq);
>> +#ifdef CONFIG_MOVE_IRQ_DESC
>> +                     /* get new one */
>> +                     desc = irq_to_desc(irq);
>> +#endif
>
> this patch adds a ton of #ifdefs to important .c files, which could all
> have been avoided by introducing a new method:
>
>        desc = irq_remap_to_desc(irq, desc);
>
> which would do something like:
>
>  static struct irq_desc *
>  irq_remap_to_desc(unsigned int irq, struct irq_desc *desc)
>  {
>  #ifdef CONFIG_MOVE_IRQ_DESC
>        return irq_to_desc(irq);
>  #else
>        return desc;
>  #endif
>  }
>
> right?

yes. will work on it.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/