linux-kernel - Re: [PATCH] Make Documentation/kobject.txt a little more coherent.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m14p1ep9e0.fsf@frodo.ebiederm.org>
Date:	Mon, 08 Dec 2008 14:52:39 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make Documentation/kobject.txt a little more coherent.

Rusty Russell <rusty@...tcorp.com.au> writes:

> While reading Documentation/kobject.txt:
>
>   Note kobject_rename does perform any locking or have a solid notion of
>   what names are valid so the provide must provide their own sanity checking
>   and serialization.
>
> I expect better: You never see me hard with time word making sentence
> coherent stuff.  Ever.
>
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Yes.  That does sound better.


> diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt
> --- a/Documentation/kobject.txt
> +++ b/Documentation/kobject.txt
> @@ -118,8 +118,8 @@ the name of the kobject, call kobject_re
>  
>      int kobject_rename(struct kobject *kobj, const char *new_name);
>  
> -Note kobject_rename does perform any locking or have a solid notion of
> -what names are valid so the provide must provide their own sanity checking
> +kobject_rename does not perform any locking or have a solid notion of
> +what names are valid so the caller must provide their own sanity checking
>  and serialization.
>  
>  There is a function called kobject_set_name() but that is legacy cruft and
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/