linux-kernel - Re: Checking link targets are NULL-terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081209171814.GA8667@infradead.org>
Date:	Tue, 9 Dec 2008 12:18:14 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Duane Griffin <duaneg@...da.com>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: Checking link targets are NULL-terminated

On Mon, Dec 08, 2008 at 02:30:03PM -0800, Andrew Morton wrote:
> Perhaps nd_set_link() is a suitable place?  Change that function so
> that it is passed a third argument (max_len) and then check that within
> nd_set_link().  Change nd_set_link() to return a __must_check-marked
> errno, change callers to handle errors appropriately.
> 
> Or something totally different ;)  But along those lines?

Note that XFS and possibly other filesystem don't store the NULL
termination on disk.  So having a follow_link interface that uses a
counted string would be a nice little optimization for the XFS
follow_link / readlink implementation.   But I'm not really sure it's
worth complicating the VFS for that little gem.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/