linux-kernel - Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493EE339.1070806@garzik.org>
Date:	Tue, 09 Dec 2008 16:29:29 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Jeff Garzik <jgarzik@...hat.com>,
	Alexandru Romanescu <a_romanescu@...oo.co.uk>,
	Tejun Heo <tj@...nel.org>, Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend

Jiri Slaby wrote:
> Commit
> ata_piix: add borked Tecra M4 to broken suspend list
> introduced DMI variables checking, but they can be null, so that
> we possibly dereference null.
> 
> Check if they are null and avoid checks in that case.
> 
> Solves:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Jeff Garzik <jgarzik@...hat.com>
> Cc: Alexandru Romanescu <a_romanescu@...oo.co.uk>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
> ---
>  drivers/ata/ata_piix.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)

Note that the original version of this patch went upstream last night...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/