linux-kernel - Re: [PATCH] amiflop: get rid of sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081209082608.GA10651@Redstar.dorchain.net>
Date:	Tue, 9 Dec 2008 09:26:08 +0100
From:	Joerg Dorchain <joerg@...chain.net>
To:	Andreas Bombe <aeb@...ian.org>
Cc:	linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] amiflop: get rid of sleep_on calls

On Mon, Dec 08, 2008 at 04:59:38PM +0000, Andreas Bombe wrote:
> The replacement for the unconditional sleep_on() in fd_motor_on() is a
> complete_all() together with a INIT_COMPLETION() before the mod_timer()
> call.  It appears to me that fd_motor_on() might be called concurrently
> and fd_select() does not guarantee mutual exclusivity in the case the
> same drive gets selected again.

Selecting the same drive repeatly does not matter. The selected
drive is the one the next command or transfer applies to.

It is possible to select one drive, start the motor, select the
next one, start the motor, as long as as trasnfer is tried until
the drive is up to speed (either by signal or the timeout)

At first glance, the patch looks ok.

Bye,

Joerg

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)