lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Dec 2008 10:59:00 +0100 From: Laurent Pinchart <laurent.pinchart@...net.be> To: Oliver Neukum <oliver@...kum.org> Cc: Wu Fengguang <fengguang.wu@...el.com>, LKML <linux-kernel@...r.kernel.org>, "Greg Kroah-Hartman" <gregkh@...e.de>, linux-usb@...r.kernel.org Subject: Re: [PATCH] usb: make printk messges more searchable On Wednesday 10 December 2008, Oliver Neukum wrote: > Am Mittwoch, 10. Dezember 2008 10:42:17 schrieb Laurent Pinchart: > > Hi Wu, > > > > On Wednesday 10 December 2008, Wu Fengguang wrote: > > > Make USB printk messages long and straightforward. One of these > > > decorated USB error messages cost me some smart efforts to locate. > > > > That would make the code break the 80 columns limit. > > > > From "Documentation/CodingStyle": > > > > "The limit on the length of lines is 80 columns and this is a strongly > > preferred limit." > > Too rigid an application is bad. The kernel must be greppable. I've also been bitten by split strings when grepping kernel source code. A cgrep that would unsplit strings before searching them would be nice :-) Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists