linux-kernel - Re: [PATCH] USB: use stack allocation for struct usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493FD2D1.8040904@codefidence.com>
Date:	Wed, 10 Dec 2008 16:31:45 +0200
From:	Gilad Ben-Yossef <gilad@...efidence.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	Laurent Pinchart <laurent.pinchart@...net.be>,
	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] USB: use stack allocation for struct usb_ctrlrequest

Wu Fengguang wrote:

>
>>> e.g. what if the memory is allocated from ZONE_HIGHMEM?
>>>   
>>>       
>> In many cases there is no problem to DMA high memory. If you happen to 
>> be working with a device that does have problems with full 32 bit 
>> addresses then GFP_DMA would be the right flag, not GFP_NOIO.
>>     
>
> For 64bit systems, we can easily go beyond 4GB physical memory.
> So at least we should add GFP_DMA32 in addition to GFP_NOIO?
>
>   
I don't think so. 64bit systems don't have ZONE_HIMEM - this is why I 
was referring to 32 bit.

More to the point, many devices don't have any issues accessing full 64 
bit addressing mode and many 64bit machines have IOMMU that will take 
care of those devices that DO have a problem. Adding this flag will just 
penalize the MM sub-system for no reason.  For the rare case where there 
is a device that cannot do 64 bit addressing in a 64 bit machine with no 
IOMMU, AFAIK bounce buffers are used to overcome the issue.

Cheers,
Gilad



-- 
Gilad Ben-Yossef 
Chief Coffee Drinker

Codefidence Ltd.
The code is free, your time isn't.(TM)

Web:    http://codefidence.com
Email:  gilad@...efidence.com
Office: +972-8-9316883 ext. 201
Fax:    +972-8-9316885
Mobile: +972-52-8260388

	The Doctor: Don't worry, Reinette, just a nightmare. 
	Everyone has nightmares. Even monsters from under the 
	bed have nightmares, don't you, monster?
	Reinette: What do monsters have nightmares about?
	The Doctor: Me! 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/