linux-kernel - Re: [PATCH] fork_init: fix division by zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081210172512.GA19584@ld0162-tx32.am.freescale.net>
Date:	Wed, 10 Dec 2008 11:25:12 -0600
From:	Scott Wood <scottwood@...escale.com>
To:	Yuri Tikhonov <yur@...raft.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>, Wolfgang Denk <wd@...x.de>,
	Detlev Zundel <dzu@...x.de>, linux-kernel@...r.kernel.org,
	Milton Miller <miltonm@....com>, linuxppc-dev@...abs.org,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
	Ilya Yanok <yanok@...raft.com>
Subject: Re: [PATCH] fork_init: fix division by zero

On Wed, Dec 10, 2008 at 01:29:12PM +0300, Yuri Tikhonov wrote:
> On Wednesday, December 10, 2008 you wrote:
> > x * y / z is parsed as (x * y) / z, not x * (y / z).
> 
>  Here we believe in preprocessor: since all PAGE_SIZE, 8, and 
> THREAD_SIZE are the constants we expect it will calculate this.
> 
>  E.g. here is the result from this line as produced by cross-gcc 
> 4.2.2:
> 
>         lis     r9,0
>         rlwinm  r29,r29,2,16,29
>         stw     r29,0(r9)
> 
>  As you see - only rotate-left, i.e. multiplication to the constant.

Yes, and also note that it is masking the result by 0xfffc, to preserve
the effect of any overflow in (x * y).

-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/