linux-kernel - Re: [PATCH] lib/idr.c: Fix bug introduced by RCU fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0812100938210.3340@localhost.localdomain>
Date:	Wed, 10 Dec 2008 09:39:10 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Manfred Spraul <manfred@...orfullife.com>
cc:	linux-kernel@...r.kernel.org, cebbert@...hat.com,
	airlied@...il.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] lib/idr.c: Fix bug introduced by RCU fix



On Wed, 10 Dec 2008, Manfred Spraul wrote:
>
> The last patch to lib/idr.c caused a bug if idr_get_new_above() was
> called on an empty idr:
> Usually, nodes stay on the same layer. New layers are added to the top
> of the tree.
> The exception is idr_get_new_above() on an empty tree: In this case,
> the new root node is first added on layer 0, then moved upwards.
> p->layer was not updated.
> 
> As usual: You shall never rely on the source code comments, they
> will only mislead you.
> 
> Signed-off-by: Manfred Spraul <manfred@...orfullife.com>

Dave Airlie - can you get this tested and acked with the people who saw 
this problem with DRI?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/