linux-kernel - Re: [PATCH] Do not pass the SLAB flags as GFP in slob kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081210202355.GC2215@localhost>
Date:	Wed, 10 Dec 2008 23:23:55 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Christoph Lameter <cl@...ux-foundation.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	linux-kernel@...r.kernel.org, Matt Mackall <mpm@...enic.com>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] Do not pass the SLAB flags as GFP in slob
	kmem_cache_create

[Christoph Lameter - Wed, Dec 10, 2008 at 02:11:23PM -0600]
| On Wed, 10 Dec 2008, Cyrill Gorcunov wrote:
| 
| > this would make the following line in slob_alloc
| >
| > 	...
| > 	if (unlikely((gfp & __GFP_ZERO) && b))
| > 		memset(b, 0, size);
| >  	...
| >
| > useless. Not sure if it will be good :)
| 
| No. GFP_ZERO is set when kmalloc etc is called. Its not set on
| kmem_cache_create.
| 

yep, Matt already pointed, I just missed first time.

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/