linux-kernel - [PATCH] block: Fix LSF default inconsistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Dec 2008 11:16:14 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Jens Axboe <axboe@...nel.dk>,
	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] block: Fix LSF default inconsistency

Configuration option LSF has a default which contradicts its help
text. The help text says "if unsure, say Y" but there is no explicit
default, and the default default is N.

This inconsistency was introduced by commit
88b9adb073b7a69a54b1b14423103bc24587ebdc. According to the commit
message, we want users to enable this option, so it should default to
Y.

Signed-off-by: Jean Delvare <khali@...ux-fr.org>
Cc: Jens Axboe <axboe@...nel.dk>
Cc: Trond Myklebust <Trond.Myklebust@...app.com>
---
 block/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.28-rc8.orig/block/Kconfig	2008-10-10 09:27:54.000000000 +0200
+++ linux-2.6.28-rc8/block/Kconfig	2008-12-11 11:09:33.000000000 +0100
@@ -60,6 +60,7 @@ config BLK_DEV_IO_TRACE
 config LSF
 	bool "Support for Large Single Files"
 	depends on !64BIT
+	default y
 	help
 	  Say Y here if you want to be able to handle very large files (2TB
 	  and larger), otherwise say N.


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/