| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081211125000.GL23742@kernel.dk> Date: Thu, 11 Dec 2008 13:50:01 +0100 From: Jens Axboe <jens.axboe@...cle.com> To: Jean Delvare <khali@...ux-fr.org> Cc: Trond Myklebust <Trond.Myklebust@...app.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] block: Fix LSF default inconsistency On Thu, Dec 11 2008, Jean Delvare wrote: > Hi Jens, > > On Thu, 11 Dec 2008 12:08:39 +0100, Jens Axboe wrote: > > Anyway, how about something like this? Totally untested... > > > > diff --git a/block/Kconfig b/block/Kconfig > > index 1ab7c15..ce566dd 100644 > > --- a/block/Kconfig > > +++ b/block/Kconfig > > @@ -24,21 +24,18 @@ menuconfig BLOCK > > if BLOCK > > > > config LBD > > - bool "Support for Large Block Devices" > > + bool "Support for Large Block Devices and files" > > depends on !64BIT > > + select LSF > > You can't select something... > > > help > > - Enable block devices of size 2TB and larger. > > + Enable block devices or files of size 2TB and larger. > > > > This option is required to support the full capacity of large > > (2TB+) block devices, including RAID, disk, Network Block Device, > > Logical Volume Manager (LVM) and loopback. > > - > > - For example, RAID devices are frequently bigger than the capacity > > - of the largest individual hard drive. > > - > > - This option is not required if you have individual disk drives > > - which total 2TB+ and you are not aggregating the capacity into > > - a large block device (e.g. using RAID or LVM). > > + > > + This option also enables support for single files larger than > > + 2TB. > > > > If unsure, say N. > > > > @@ -57,15 +54,6 @@ config BLK_DEV_IO_TRACE > > > > If unsure, say N. > > > > -config LSF > > ... that no longer exists. You must either leave the config LSF as a > bool with no label and no help file, or drop it altogether and replace > all occurrences of CONFIG_LSF in the kernel source with CONFIG_LBD. Oh right, that's pretty dumb. Lets just do the former, then a later patch can replace it completely if wanted. diff --git a/block/Kconfig b/block/Kconfig index 1ab7c15..a785e65 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -23,22 +23,22 @@ menuconfig BLOCK if BLOCK +config LSF + bool + config LBD - bool "Support for Large Block Devices" + bool "Support for Large Block Devices and files" depends on !64BIT + select LSF help - Enable block devices of size 2TB and larger. + Enable block devices or files of size 2TB and larger. This option is required to support the full capacity of large (2TB+) block devices, including RAID, disk, Network Block Device, Logical Volume Manager (LVM) and loopback. - - For example, RAID devices are frequently bigger than the capacity - of the largest individual hard drive. - - This option is not required if you have individual disk drives - which total 2TB+ and you are not aggregating the capacity into - a large block device (e.g. using RAID or LVM). + + This option also enables support for single files larger than + 2TB. If unsure, say N. @@ -57,15 +57,6 @@ config BLK_DEV_IO_TRACE If unsure, say N. -config LSF - bool "Support for Large Single Files" - depends on !64BIT - help - Say Y here if you want to be able to handle very large files (2TB - and larger), otherwise say N. - - If unsure, say Y. - config BLK_DEV_BSG bool "Block layer SG support v4 (EXPERIMENTAL)" depends on EXPERIMENTAL -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists