linux-kernel - Re: [RFC][PATCH] memcg: show real limit under hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <661de9470812110600i6097ca0q7a2d7250f6c493dc@mail.gmail.com>
Date:	Thu, 11 Dec 2008 19:30:46 +0530
From:	"Balbir Singh" <balbir@...ux.vnet.ibm.com>
To:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>
Cc:	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>
Subject: Re: [RFC][PATCH] memcg: show real limit under hierarchy

On Thu, Dec 11, 2008 at 8:54 AM, KOSAKI Motohiro
<kosaki.motohiro@...fujitsu.com> wrote:
>> I wonder other people who debugs memcg's hierarchy may use similar patches.
>> this is my one.
>> comments ?
>> ==
>> From:KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>>
>> Show "real" limit of memcg.
>> This helps my debugging and maybe useful for users.
>>
>> While testing hierarchy like this
>>
>>       mount -t cgroup none /cgroup -t memory
>>       mkdir /cgroup/A
>>       set use_hierarchy==1 to "A"
>>       mkdir /cgroup/A/01
>>       mkdir /cgroup/A/01/02
>>       mkdir /cgroup/A/01/03
>>       mkdir /cgroup/A/01/03/04
>>       mkdir /cgroup/A/08
>>       mkdir /cgroup/A/08/01
>>       ....
>> and set each own limit to them, "real" limit of each memcg is unclear.
>> This patch shows real limit by checking all ancestors in memory.stat.
>>
>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>
> Great!
>
> I hoped to use this patch at hierarchy inactive_ratio debugging ;)

I like this very much too

I would prefer to use

min_limit = min(tmp, min_limit); and similarly for min_memsw_limit

Acked-by: Balbir Singh <balbir@...ux.vnet.ibm.com>

Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/